Skip to content

Conversation

v0i0
Copy link

@v0i0 v0i0 commented Aug 13, 2025

No description provided.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 13, 2025
Copy link
Contributor

@jansel jansel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test and __main__ for this similar to the other examples?

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from fed64ce to 157f1e3 Compare August 14, 2025 18:47
"tritonbench.operators.fused_linear_jsd.operator",
"examples.fused_linear_jsd",
"fused_linear_jsd_fwd_tritonbench",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like to show result of running the benchmark with --metrics accuracy, to see if all accuracy checks pass?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where should i show that, just here?

(B*T, H) liger_lm_head_jsd-accuracy inductor_lm_head_jsd-accuracy helion_fused_linear_jsd_fwd_tritonbench-accuracy
(1024, 4096) 1 1 1
(2048, 4096) 1 1 1
(4096, 4096) 1 1 1
(8192, 4096) 1 1 1
average 1 1 1

@@ -0,0 +1,122 @@
from __future__ import annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test to test_examples.py too, following other examples in this folder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from 157f1e3 to 435b56f Compare August 18, 2025 17:38
@v0i0 v0i0 force-pushed the examples/fused_linear_jsd branch from 435b56f to 392a26d Compare August 18, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants