-
Notifications
You must be signed in to change notification settings - Fork 24
[example] fused_linear_jsd #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a test and __main__
for this similar to the other examples?
fed64ce
to
157f1e3
Compare
"tritonbench.operators.fused_linear_jsd.operator", | ||
"examples.fused_linear_jsd", | ||
"fused_linear_jsd_fwd_tritonbench", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you like to show result of running the benchmark with --metrics accuracy
, to see if all accuracy checks pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where should i show that, just here?
(B*T, H) | liger_lm_head_jsd-accuracy | inductor_lm_head_jsd-accuracy | helion_fused_linear_jsd_fwd_tritonbench-accuracy |
---|---|---|---|
(1024, 4096) | 1 | 1 | 1 |
(2048, 4096) | 1 | 1 | 1 |
(4096, 4096) | 1 | 1 | 1 |
(8192, 4096) | 1 | 1 | 1 |
average | 1 | 1 | 1 |
@@ -0,0 +1,122 @@ | |||
from __future__ import annotations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test to test_examples.py too, following other examples in this folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
157f1e3
to
435b56f
Compare
435b56f
to
392a26d
Compare
No description provided.