Skip to content

Manually cherry-pick "Pin huggingface_hub<1.0" #15667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2025
+5 −5
Merged

Manually cherry-pick "Pin huggingface_hub<1.0" #15667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b1a418
Pin huggingface_hub<1.0 (#15399)
GregoryComer Oct 27, 2025
1293f9d
Pin huggingface_hub in more places (#15403)
GregoryComer Oct 27, 2025
a7f9ac3
Manual fixup
GregoryComer Nov 7, 2025
9afbe27
Update test_wheel_package_qnn.sh
GregoryComer Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/scripts/test_wheel_package_qnn.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ run_core_tests () {
echo "=== [$LABEL] Installing wheel & deps ==="
"$PIPBIN" install --upgrade pip
"$PIPBIN" install "$WHEEL_FILE"
"$PIPBIN" install torch=="2.9.0"
"$PIPBIN" install torch=="2.9.1"
Copy link
Contributor

@lucylq lucylq Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended?

Copy link
Member Author

@GregoryComer GregoryComer Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - good question. It's not strictly part of the original pick but we want torch==2.9.1 for 1.0.1 and I was seeing a related issue on CI, so I stuck that fix in.

"$PIPBIN" install --pre torchao --index-url "https://download.pytorch.org/whl/nightly/cpu"

echo "=== [$LABEL] Import smoke tests ==="
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/trunk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,7 +612,7 @@ jobs:
conda activate "${CONDA_ENV}"

PYTHON_EXECUTABLE=python bash .ci/scripts/setup-linux.sh --build-tool cmake
pip install -U "huggingface_hub[cli]"
pip install -U "huggingface_hub[cli]<1.0"

bash .ci/scripts/test_torchao_huggingface_checkpoints.sh ${{ matrix.model }} ${{ matrix.test_with_runner && '--test_with_runner' || '' }}

Expand Down Expand Up @@ -809,7 +809,7 @@ jobs:
echo "::endgroup::"

echo "::group::Setup Huggingface"
pip install -U "huggingface_hub[cli]" accelerate
pip install -U "huggingface_hub[cli]<1.0" accelerate
huggingface-cli login --token $SECRET_EXECUTORCH_HF_TOKEN
OPTIMUM_ET_VERSION=$(cat .ci/docker/ci_commit_pins/optimum-executorch.txt)
pip install git+https://github.com/huggingface/optimum-executorch.git@${OPTIMUM_ET_VERSION}
Expand Down Expand Up @@ -905,7 +905,7 @@ jobs:
echo "::endgroup::"

echo "::group::Set up Huggingface"
${CONDA_RUN} pip install -U "huggingface_hub[cli]" accelerate
${CONDA_RUN} pip install -U "huggingface_hub[cli]<1.0" accelerate
${CONDA_RUN} huggingface-cli login --token $SECRET_EXECUTORCH_HF_TOKEN
OPTIMUM_ET_VERSION=$(cat .ci/docker/ci_commit_pins/optimum-executorch.txt)
${CONDA_RUN} pip install git+https://github.com/huggingface/optimum-executorch.git@${OPTIMUM_ET_VERSION}
Expand Down
2 changes: 1 addition & 1 deletion examples/models/llama/install_requirements.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
# Install tokenizers for hf .json tokenizer.
# Install snakeviz for cProfile flamegraph
# Install lm-eval for Model Evaluation with lm-evalution-harness.
pip install hydra-core huggingface_hub tiktoken torchtune sentencepiece tokenizers snakeviz lm_eval==0.4.5 blobfile
pip install hydra-core "huggingface_hub<1.0" tiktoken torchtune sentencepiece tokenizers snakeviz lm_eval==0.4.5 blobfile

# Call the install helper for further setup
python examples/models/llama/install_requirement_helper.py
Loading