Skip to content

Conversation

mansnils
Copy link
Collaborator

@mansnils mansnils commented Aug 29, 2025

Change-Id: I9a57e61364d110419af89a5e5a34cba0eb8f17da
@mansnils mansnils added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Aug 29, 2025
@mansnils mansnils requested a review from digantdesai as a code owner August 29, 2025 18:07
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13819

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 New Failures, 1 Cancelled Job, 8 Unrelated Failures

As of commit 33ff8c6 with merge base ebdd12d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2025
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

-DEXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR=ON \
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \
-DEXECUTORCH_BUILD_XNNPACK=OFF \
-DEXECUTORCH_BUILD_VULKAN=ON \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will build and link ET Vulkan backend, ok for now but why do we need this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the platform and runtime environment provided by the Vulkan delegate

Copy link
Contributor

@digantdesai digantdesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of high level questions,
(1) how do you envision evolution of these setup, build, run script with ethos?
(2) why not add the scripts introduced in the PR on the CI? I might be missing something in terms of runtime dependency but I am asking as a way to test these code you are introducing. If not run, let's at least build?

@mansnils
Copy link
Collaborator Author

Couple of high level questions, (1) how do you envision evolution of these setup, build, run script with ethos? (2) why not add the scripts introduced in the PR on the CI? I might be missing something in terms of runtime dependency but I am asking as a way to test these code you are introducing. If not run, let's at least build?

Thanks for your comments.

  1. We plan to refactor this, specially the setup part
  2. The patch has potential for merge conflicts, in fact one already happened. I think the fastest way is to merge it then enable CI as a second patch

@mansnils
Copy link
Collaborator Author

mansnils commented Sep 1, 2025

Ethos-U failures unrelated to this PR

@zingo zingo merged commit afb09d0 into pytorch:main Sep 1, 2025
234 of 246 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants