-
Notifications
You must be signed in to change notification settings - Fork 654
Arm backend: Add NGP unit test scripts #13819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Change-Id: I9a57e61364d110419af89a5e5a34cba0eb8f17da
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13819
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 3 New Failures, 1 Cancelled Job, 8 Unrelated FailuresAs of commit 33ff8c6 with merge base ebdd12d ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
-DEXECUTORCH_BUILD_EXTENSION_FLAT_TENSOR=ON \ | ||
-DEXECUTORCH_BUILD_EXTENSION_TENSOR=ON \ | ||
-DEXECUTORCH_BUILD_XNNPACK=OFF \ | ||
-DEXECUTORCH_BUILD_VULKAN=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will build and link ET Vulkan backend, ok for now but why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use the platform and runtime environment provided by the Vulkan delegate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of high level questions,
(1) how do you envision evolution of these setup, build, run script with ethos?
(2) why not add the scripts introduced in the PR on the CI? I might be missing something in terms of runtime dependency but I am asking as a way to test these code you are introducing. If not run, let's at least build?
Thanks for your comments.
|
Ethos-U failures unrelated to this PR |
Prepare scripts for CI.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218