Skip to content

Conversation

samanklesaria
Copy link
Collaborator

We deprecated the CUTC decoder for the 2.8 release as we thought we might need to remove all C++ extensions from the package. However, realizing now that this does not need to be the case, we should un-deprecate the functionality.

Copy link

pytorch-bot bot commented Aug 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4055

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures

As of commit b0650da with merge base a645da6 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 20, 2025
@samanklesaria samanklesaria marked this pull request as ready for review August 20, 2025 16:49
@samanklesaria samanklesaria requested a review from a team as a code owner August 20, 2025 16:49
@NicolasHug
Copy link
Member

thanks, let's merge it at the end once we finished the migrations

@samanklesaria
Copy link
Collaborator Author

What other deprecation logic needs to be removed? A git grep (after merging the current PRs in the queue - see psuedo_main for what this looks like) gives no results.

@samanklesaria
Copy link
Collaborator Author

I actually believe this PR needs to be merged in next, due to a change in how sphinx is working nowadays. In all other PRs now, we are getting an error like this when building documentation locally:

Traceback (most recent call last):
  File "/home/samanklesaria/world/.pixi/envs/default/lib/python3.12/site-packages/sphinx/util/inspect.py", line 461, in safe_getattr
    return getattr(obj, name, *defargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/samanklesaria/world/.pixi/envs/default/lib/python3.12/site-packages/torchaudio/models/decoder/__init__.py", line 42, in __getattr__
    item = dropping_support(orig_item)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/samanklesaria/world/.pixi/envs/default/lib/python3.12/site-packages/torchaudio/_internal/module_utils.py", line 84, in decorator
    wrapped = wrap_deprecated(func, f"{func.__module__}.{func.__name__}", direction, version=version, remove=remove)
TypeError: __type_params__ must be set to a tuple

This suggests that if we just merged this PR first, which eliminating the CUTC warnings, this error would go away. Note that this error does not show up in the CI: the CI logs for sphinx only show the exit code and suppress all other output.

@pearu
Copy link
Collaborator

pearu commented Sep 2, 2025

This PR requires:

@pearu pearu added this to the 2.9 milestone Sep 2, 2025
@samanklesaria
Copy link
Collaborator Author

I'm not actually sure this should be added to the 2.9 milestone. I believe Nicholas only wanted to remove the deprecations once the stable ABI ports are complete. I'll resolve the new conflicts, but I think this PR should be set aside for now.

@pearu pearu modified the milestones: 2.9, 2.10 Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants