-
Notifications
You must be signed in to change notification settings - Fork 719
Remove deprecation of CUTC decoder #4055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4055
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit b0650da with merge base a645da6 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
thanks, let's merge it at the end once we finished the migrations |
What other deprecation logic needs to be removed? A git grep (after merging the current PRs in the queue - see |
I actually believe this PR needs to be merged in next, due to a change in how sphinx is working nowadays. In all other PRs now, we are getting an error like this when building documentation locally:
This suggests that if we just merged this PR first, which eliminating the CUTC warnings, this error would go away. Note that this error does not show up in the CI: the CI logs for sphinx only show the exit code and suppress all other output. |
This PR requires:
|
I'm not actually sure this should be added to the 2.9 milestone. I believe Nicholas only wanted to remove the deprecations once the stable ABI ports are complete. I'll resolve the new conflicts, but I think this PR should be set aside for now. |
We deprecated the CUTC decoder for the 2.8 release as we thought we might need to remove all C++ extensions from the package. However, realizing now that this does not need to be the case, we should un-deprecate the functionality.