Skip to content

Conversation

ScottTodd
Copy link
Contributor

See https://cmake.org/cmake/help/latest/command/file.html#path-conversion. Paths stored in environment variables may use / or \ (e.g. on Windows), while cmake-style paths always use /.

This fixes configure errors like:

CMake Error at D:/b/audio_main/build/temp.win-amd64-cpython-312/Release/CMakeFiles/CMakeScratch/TryCompile-y9h2qt/CMakeLists.txt:2 (set):
  Syntax error in cmake code at

    D:/b/audio_main/build/temp.win-amd64-cpython-312/Release/CMakeFiles/CMakeScratch/TryCompile-y9h2qt/CMakeLists.txt:2

  when parsing string

    D:/projects/TheRock/external-builds/pytorch/.venv/Lib/site-packages/_rocm_sdk_devel/cmake/;D:\projects\TheRock\external-builds\pytorch\.venv\Lib\site-packages\_rocm_sdk_devel/lib/cmake/hip;D:/b/audio_main/cmake

  Invalid character escape '\p'.

(note the mixed usage of \ and / in that string)

@ScottTodd ScottTodd requested a review from a team as a code owner July 24, 2025 20:23
Copy link

pytorch-bot bot commented Jul 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3991

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 15 Pending

As of commit d62c3a1 with merge base 46b5dc6 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ScottTodd
Copy link
Contributor Author

Copy link

@jeffdaily jeffdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but I don't have any real authority in this torchaudio repo.

@ScottTodd
Copy link
Contributor Author

Thanks. Do you know who we should ask then? Looks like most commit activity in the last few months (https://github.com/pytorch/audio/graphs/contributors?from=5%2F10%2F2025) has been from @samanklesaria

@atalman
Copy link
Contributor

atalman commented Aug 19, 2025

cc @NicolasHug

@jammm
Copy link

jammm commented Sep 3, 2025

cc @NicolasHug

@NicolasHug would appreciate your review here :)

@NicolasHug NicolasHug merged commit 2e30055 into pytorch:main Sep 4, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants