Update deprecated.sphinx.deprecated signature #6005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature was changed in Deprecated 1.2.13.
hauntsaninja
reviewed
Sep 5, 2021
There was a problem hiding this comment.
Seems fine to unblock CI, but I think these stubs aren't right. E.g., this deprecated definitely takes "directive" and "adapter_cls" kwargs: https://github.com/tantale/deprecated/blob/f5eebcddaebf2dafd3f734e85c4c85cbbae9aef4/deprecated/sphinx.py#L253 and I think potentially arbitrary additional kwargs as well: https://github.com/tantale/deprecated/blob/f5eebcddaebf2dafd3f734e85c4c85cbbae9aef4/deprecated/classic.py#L267
|
Yeah, I noticed that too, but ignored it for now to get this out quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature was changed in Deprecated 1.2.13.