[mypyc] feat: new primitive for int.bit_length
#19673
Conversation
for more information, see https://pre-commit.ci
mypyc/test-data/run-integers.test
Outdated
| def bit_length(n: int) -> int: | ||
| return n.bit_length() | ||
| def test_bit_length() -> None: | ||
| assert bit_length(0) == 0 |
There was a problem hiding this comment.
Minor: This would be a bit more robust if you'd have say bit_length_python function that does return getattr(n, "bit_length")() and you can assert that bit_length(n) == bit_length_python(n).
There was a problem hiding this comment.
Well that's odd, I implemented the tests as you asked here but now we get segfaults on Python3.14
There was a problem hiding this comment.
Also on the 32-bit test runner
There was a problem hiding this comment.
okay... well after implementing your bitscan idea the issue has resolved itself on python3.14... somehow
I still don't understand how getattr(x, "bit_length")() would cause segfault behavior
|
I'm not entirely sure how to proceed here, I can't think of any reason our use of |
This PR adds a new primitive for
int.bit_lengthand is already ready for review.