Skip to content

Conversation

@sobolevn
Copy link
Member

Two main changes:

  1. Always use secure permissions, when some workflow does not do anything, it has to be contents: read only
  2. Be more consistent with canceling workflows

@sobolevn sobolevn requested a review from hauntsaninja August 26, 2023 08:21
@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@sobolevn sobolevn merged commit 6c16143 into master Aug 29, 2023
@sobolevn sobolevn deleted the imporove-github-actions branch August 29, 2023 20:12
@sobolevn
Copy link
Member Author

@AlexWaygood
Copy link
Member

Looks like I broke something: https://github.com/python/mypy/actions/runs/6017051995/job/16322380076

Nah, something was already broken — take a look at the CI on #15986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants