gh-116127: PEP-705: Add ReadOnly support for TypedDict
#116350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Can you also add this to What's New?
JelleZijlstra
approved these changes
Mar 12, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks! Just some wording suggestions.
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Mar 12, 2024
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
…hon#116350) Co-authored-by: Jelle Zijlstra <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…hon#116350) Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the credit for this change goes to the original authors of python/typing_extensions@0b0166d (in the same order as GitHub shows it):
My extra change is that
get_type_hints(include_extras=False)now removesReadOnlyspecial form. See python/typing_extensions#349 backport PR fortyping-extensions.📚 Documentation preview 📚: https://cpython-previews--116350.org.readthedocs.build/