GH-98831: Identify instructions that don't use oparg #100957
Conversation
For these the instr_format field uses I_ instead of IB. Register instructions use I_, IB, IBB_, IBBB, etc.
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Looks mostly good, just a bit confused by the register formats you're generating.
| fmt = "I" + "B"*num_regs + "_"*num_dummies | ||
| else: | ||
| fmt = "IB" | ||
| if variable_used(inst.block, "oparg"): |
There was a problem hiding this comment.
We don't know the actual opcode values yet, do we? If so, maybe we want to warn or something if this conflicts with HAVE_ARGUMENT.
There was a problem hiding this comment.
Alas, we don't. I'd have to load opcode.py using the hack from your PR, which feels more infrastructure than I want to invest in for now (nothing is using the opcode metadata yet).
|
When you're done making the requested changes, leave the comment: |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brandtbucher: please review the changes made to this pull request. |
3 participants
For these the instr_format field uses I_ instead of IB.
Register instructions use I_, IB, IBB_, IBBB, etc.