fix(github-action)!: resolve command injection vulnerability in action script #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codejedi365
force-pushed
the
fix/github-action-cmd-injection-vulnerability
branch
4 times, most recently
from
4bb4c61 to
a3ef23b
Compare
…n script Prevents the malicious execution of arbitrary code when a command injection is defined in the action yaml as part of the action parameter specification. Low impact exploitation if proper least privilege is implemented and pull request code is reviewed before merging to a release branch. BREAKING CHANGE: The `root_options` action input parameter has been removed because it created a command injection vulernability for arbitrary code to execute within the container context of the GitHub action if a command injection code was provided as part of the `root_options` parameter string. To eliminate the vulnerability, each relevant option that can be provided to `semantic-release` has been individually added as its own parameter and will be processed individually to prevent command injection. Please review our `Github Actions Configuration`__ page on the Python Semantic Release Documentation website to review the newly available configuration options that replace the `root_options` parameter. __ https://python-semantic-release.readthedocs.io/en/stable/automatic-releases/github-actions.html Resolves: python-semantic-release#55
codejedi365
force-pushed
the
fix/github-action-cmd-injection-vulnerability
branch
from
a3ef23b to
4e97de7
Compare
codejedi365
changed the title
🎉 This PR has been published as part of v10.0.0 🎉You can find more information about this release on the GitHub Releases page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Rationale
Prevents the malicious execution of arbitrary code when a command injection is defined in the action yaml as part of the action parameter specification. Low impact exploitation if proper least privilege is implemented and pull request code is reviewed before merging to a release branch.
Includes a breaking change as the
root_optionsaction input parameter has been removed because it created a command injection vulnerability for arbitrary code to execute within the container context of the GitHub action if a command injection code was provided as part of theroot_optionsparameter string. To eliminate the vulnerability, each relevant option that can be provided tosemantic-releasehas been individually added as its own parameter and will be processed individually to prevent command injection. Please review ourGithub Actions Configurationpage on the Python Semantic Release Documentation website to review the newly available configuration options that replace theroot_optionsparameter.How did you test?
Added an additional test to run the github action simulator with the new parameter
config_file.