Start QOI decoding with a zero-initialized array of previously seen pixels #9008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This originated in discussion at #9007
When starting to decode a QOI image, https://qoiformat.org/qoi-specification.pdf states that
Pillow/src/PIL/QoiImagePlugin.py
Lines 43 to 54 in b844007
However, the part of the specification describing
_previously_seen_pixels
states thatWhile I don't think these two statements from specification fit together in the most natural way, the code that currently exists is not 'initialized' at zero exactly - we're starting out with the previous pixel value of (0, 0, 0, 255). This PR stops that.