Skip to content

Wrong behaviour for enum keyword #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Wrong behaviour for enum keyword #1208

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9bf13c
Use equal for enum validator
bjoern-otto Jan 8, 2024
9a3d4a7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions jsonschema/_keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
find_additional_properties,
find_evaluated_item_indexes_by_schema,
find_evaluated_property_keys_by_schema,
unbool,
uniq,
)
from jsonschema.exceptions import FormatError, ValidationError
Expand Down Expand Up @@ -264,11 +263,7 @@ def dependentSchemas(validator, dependentSchemas, instance, schema):


def enum(validator, enums, instance, schema):
if instance == 0 or instance == 1:
unbooled = unbool(instance)
if all(unbooled != unbool(each) for each in enums):
yield ValidationError(f"{instance!r} is not one of {enums!r}")
elif instance not in enums:
if all(not equal(each, instance) for each in enums):
yield ValidationError(f"{instance!r} is not one of {enums!r}")


Expand Down