Improve Docker Support #1145
Merged
Improve Docker Support #1145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serroba
force-pushed
the
improve-docker-support
branch
from
2b8070f to
ffa4c94
Compare
serroba
commented
Oct 27, 2022
serroba
commented
Oct 27, 2022
Dockerfile
Outdated
| COPY . . | ||
|
|
||
| RUN pip3 install -r requirements.txt && pip3 install -e . | ||
| RUN pip install -r requirements.txt && pip install -e . |
There was a problem hiding this comment.
in the container there is no other python version so no need to keep the references to pip3
There was a problem hiding this comment.
I prefer to keep pip3, that way we do not get side effects if python2 is installed.
There was a problem hiding this comment.
Sure I'll update. However, the scenario you are talking about it's not something that would happen accidentally.
Requires modify the dockerfile. However, I don't mind to revert the change
janiversen
requested changes
Oct 27, 2022
Dockerfile
Outdated
| COPY . . | ||
|
|
||
| RUN pip3 install -r requirements.txt && pip3 install -e . | ||
| RUN pip install -r requirements.txt && pip install -e . |
There was a problem hiding this comment.
I prefer to keep pip3, that way we do not get side effects if python2 is installed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Improve docker support by adding a default working CMD instruction.
By default tries to run the modbus server in a headless mode.
Additionally, adding a bit more details to the documentation
Why?
This makes the container more useful and friendly. It becomes ready to use with no much more to do.
Proof it's working