Add Constant fold helper #6150
Add Constant fold helper #6150
Conversation
ricardoV94
force-pushed
the
constant_fold_helper
branch
from
858f124 to
789e07c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6150 +/- ##
==========================================
- Coverage 91.93% 89.28% -2.65%
==========================================
Files 101 91 -10
Lines 20948 20717 -231
==========================================
- Hits 19258 18497 -761
- Misses 1690 2220 +530
|
| if not all(isinstance(folded_x, Constant) for folded_x in folded_xs): | ||
| raise NotConstantValueError |
There was a problem hiding this comment.
What is the implication if we remove this? folded_xs would just be a tensor?
I am thinking that instead of raising error, maybe we can make the function being "best effort constant fold".
There was a problem hiding this comment.
It would be a tensor, but we cloned the graph, so it has nothing to do with the original one (except for shared inputs). If you tried to evaluate with the original inputs you would get unused input and missing input errors
There was a problem hiding this comment.
LOL i was looking at this line and feeling we are being a bit more too aggressive - seems my hunch was justified.
There was a problem hiding this comment.
You mean the follow up PR? If so, yeah I thought I had already pushed it and you were looking at it. My bad :P
|
Oops a test was failing... I thought it was just the pre-commit issue that was fixed in the meantime |
ricardoV94
added
bug
no releasenotes
2 participants
What is this PR about?
This PR refactors repeated constant fold logic into a helper function in aesaraf
Checklist
Major / Breaking Changes
Bugfixes / New features
constant_foldhelperDocs / Maintenance