Skip to content

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Aug 21, 2022

In the process of convincing myself that conda-forge/pymc-feedstock#60 was a good idea, I checked for sys.platform usages, and found these unused variables. 😄 ✂️

I don't seem to have labels permissions, but I suggest no releasenotes and tests

What is this PR about?
...

Checklist

Major / Breaking Changes

  • ...

Bugfixes / New features

  • ...

Docs / Maintenance

  • Remove unused IS_FLOAT32 and IS_WINDOWS from test_ode

@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #6057 (2569f57) into main (9024c2b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6057   +/-   ##
=======================================
  Coverage   89.07%   89.07%           
=======================================
  Files          72       72           
  Lines       12931    12931           
=======================================
  Hits        11518    11518           
  Misses       1413     1413           

@maresb maresb marked this pull request as ready for review August 21, 2022 14:05
@twiecki twiecki merged commit f7315a3 into pymc-devs:main Aug 22, 2022
@twiecki
Copy link
Member

twiecki commented Aug 22, 2022

Thanks @maresb!

@maresb maresb deleted the remove-unused-vars branch August 22, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants