Raise error if MCP server __aexit__ is called when _running_count is already 0 #2696
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicociner
changed the title
|
@federicociner What do you think about instead raising an error from |
|
@DouweM yea that would work too! Would that be your preference here? We could actually do both. |
|
@federicociner Yeah that'd be my preference, so we couldn't get into this invalid state to begin with. Then we shouldn't need the |
|
@DouweM yup makes sense, I'll update the PR. |
federicociner
force-pushed
the
update-mcp-is-running-logic
branch
from
374da84 to
a0c5bfd
Compare
federicociner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently had a situation in our agentic CLI tool where we a block of code that had called
__aexit__on an already stopped server and the running count dropped below 0 to -1.However, when trying to debug and compare active/running vs. stopped servers, we were relying on the
is_runningproperty and we were incorrectly seeing stopped servers being classified as running servers. I believe this is becausebool(-1)evaluates to True, so this PR simplifies the property condition to only consider a server as running if the_running_countis greater than 0.