FunctionToolset() sets default require_parameter_descriptions for tool wrapper #2601
+68
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docstring_format doesn't raise errors if there is a mismatch in docstring type or a missing docstring. So setting it at the toolset level isn't useful.
g-eoj
changed the title
DouweM
requested changes
Aug 25, 2025
| @@ -36,23 +36,27 @@ class FunctionToolset(AbstractToolset[AgentDepsT]): | |||
| max_retries: int | |||
| tools: dict[str, Tool[Any]] | |||
| _id: str | None | |||
| _default_require_parameter_descriptions: bool | |||
There was a problem hiding this comment.
I think we can drop the _default_ prefix here, and make it a proper dataclass field.
Suggested change
| _default_require_parameter_descriptions: bool | |
| require_parameter_descriptions: bool |
| @@ -77,7 +81,7 @@ def tool( | |||
| retries: int | None = None, | |||
| prepare: ToolPrepareFunc[AgentDepsT] | None = None, | |||
| docstring_format: DocstringFormat = 'auto', | |||
| require_parameter_descriptions: bool = False, | |||
| require_parameter_descriptions: bool | None = None, | |||
| schema_generator: type[GenerateJsonSchema] = GenerateToolJsonSchema, | |||
There was a problem hiding this comment.
I think it'd make sense to also add toolset-wide defaults for docstring_format and schema_generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2587
This PR changes function signatures so may be considered breaking. However it should be backwards compatible still. Specifically, the types for two arguments are changed:
Changes to: