Skip to content

Fix NoneType object is not subscriptable from _insert_filtered_annotations #3444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix NoneType object is not subscriptable from _insert_filtered_annotations #3444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pypdf/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3052,7 +3052,14 @@ def _insert_filtered_annotations(
outlist.append(ano.clone(self).indirect_reference)
else:
d = cast("ArrayObject", d)
p = self._get_cloned_page(d[0], pages, reader)
try:
p = self._get_cloned_page(d[0], pages, reader)
except TypeError:
# There are cases where the IndirectObject is not None, but d[0] will fail:
Copy link
Collaborator

@stefan6419846 stefan6419846 Aug 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically want to check for not is_null_or_none(d[0].get_object())? Having this explicitly is preferred over more costly exception handling.

# TypeError: 'NoneType' object is not subscriptable
# in generic/_base.py, in __getitem__
# at `return self._get_object_with_check()[key]`
continue
if p is not None:
anc = ano.clone(self, ignore_fields=("/D",))
cast("DictionaryObject", anc["/A"])[
Expand Down
Loading