Skip to content

Conversation

larsga
Copy link
Contributor

@larsga larsga commented Aug 21, 2025

This optimization solves the performance issue introduced by PR #3400.

Without this optimization test_merger.py takes 124 seconds on my laptop after PR 3400. With this optimization it takes 6.6 seconds.

Very likely this optimization will benefit other code as well.

@larsga larsga force-pushed the optimize-links branch 2 times, most recently from 96cb457 to ae6835f Compare August 21, 2025 08:31
@larsga
Copy link
Contributor Author

larsga commented Aug 21, 2025

@stefan6419846 I need some help with this. ruff and Python both are complaining about Dict in my added code, claiming it's not declared. It is imported on line 39, though. And other code uses it in exactly the same way, without ruff or Python complaining. It works for me in both Python and ruff locally. What is going on?

@stefan6419846
Copy link
Collaborator

Please try to rebase on the latest main - your base appears to be outdated and the corresponding import is gone in main.

@larsga larsga force-pushed the optimize-links branch 2 times, most recently from 5f25cc9 to 2c3fb66 Compare August 21, 2025 19:17
Copy link

codecov bot commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.98%. Comparing base (bc318d7) to head (8465c0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3442   +/-   ##
=======================================
  Coverage   96.97%   96.98%           
=======================================
  Files          54       54           
  Lines        9337     9344    +7     
  Branches     1711     1713    +2     
=======================================
+ Hits         9055     9062    +7     
  Misses        168      168           
  Partials      114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larsga
Copy link
Contributor Author

larsga commented Aug 21, 2025

That worked. Thank you! The PR should be ready now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants