Skip to content

BUG: Remove unused objects when cloning_from #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

BUG: Remove unused objects when cloning_from #1926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pypdf/_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,6 +1003,7 @@ def clone_reader_document_root(self, reader: PdfReader) -> None:
Args:
reader: PdfReader from the document root should be copied.
"""
self._objects.clear()
self._root_object = cast(DictionaryObject, reader.trailer[TK.ROOT].clone(self))
self._root = self._root_object.indirect_reference # type: ignore[assignment]
self._pages = self._root_object.raw_get("/Pages")
Expand Down
14 changes: 14 additions & 0 deletions tests/test_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1439,3 +1439,17 @@ def test_iss1862():
writer.append(BytesIO(get_pdf_from_url(url, name=name)))
# check that "/B" is in the font
writer.pages[0]["/Resources"]["/Font"]["/F1"]["/CharProcs"]["/B"].get_data()


def test_empty_objects_before_cloning():
pdf_path = RESOURCE_ROOT / "crazyones.pdf"
reader = PdfReader(pdf_path)
writer = PdfWriter(clone_from=reader)
nb_obj_reader = len(reader.xref_objStm) + sum(
len(reader.xref[i]) for i in reader.xref
)
nb_obj_reader -= 1 # for trailer
nb_obj_reader -= len(
{x: 1 for x, y in reader.xref_objStm.values()}
) # to remove object streams
assert len(writer._objects) == nb_obj_reader