Quote strings in Show instances #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
approved these changes
Aug 6, 2017
Contributor
hdgarrood
left a comment
hdgarrood
left a comment
There was a problem hiding this comment.
Looks good, thanks! I think the only question is whether we treat this as a breaking- or patch-level change. I'm tempted to say the latter, as there's no Read class and just in general I think it's very unlikely that people are relying on the current behaviour.
Contributor
|
Patch, I agree. |
Contributor
|
Thanks! |
Member
|
Too late now, but I would have voted for patch also 😄 |
Contributor
|
I did make a patch change, I bumped the version to 3.3.1. |
Member
|
Yeah I know, I just meant my comment was too late to have swayed it were it not unanimous. |
Contributor
|
Sorry for rushing, it just seemed harmless enough in this case either way, since people shouldn't be relying on (bad) |
Member
|
Haha no worries, it was supposed to be a joke... I should have stayed quiet 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually in Haskell, strings are shown with quotes, so I presume PureScript follows the same convention.