Skip to content

Update to v0.14.0-rc3 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2020
Merged

Update to v0.14.0-rc3 #20

merged 5 commits into from
Dec 11, 2020

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez
Copy link
Contributor Author

Someone more familiar with this library should clarify whether we need these kind annotations to be polykinded or just kinded to Type.

@thomashoneyman
Copy link
Contributor

@JordanMartinez I'm not completely confident, but I suspect these can all be fixed to Type (which is the conservative, preserve-existing-code move as well). If you fix them to Type then I'm happy to merge (or feel free to go ahead yourself).

@thomashoneyman thomashoneyman added the purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0 label Dec 10, 2020
thomashoneyman
thomashoneyman reviewed Dec 11, 2020
View reviewed changes
.github/workflows/ci.yml

jobs:
build:
runs-on: ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest

thomashoneyman
thomashoneyman reviewed Dec 11, 2020
View reviewed changes
package.json Outdated
"purescript-psa": "^0.8.0",
"rimraf": "^3.0.2"
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the other contrib repositories we've just updated the CI.yml file directly, without introducing Pulp to the project (or a new package.json file). Can we just update the Bower file and the ci.yml file instead of adding these new files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other words, the migration script for core / web / node isn't suitable for contrib.

@JordanMartinez
Copy link
Contributor Author

How about now?

@JordanMartinez
Copy link
Contributor Author

CI builds now.

thomashoneyman
thomashoneyman reviewed Dec 11, 2020
View reviewed changes
@thomashoneyman thomashoneyman merged commit 129661b into purescript-contrib:main Dec 11, 2020
@JordanMartinez JordanMartinez deleted the updateTo14 branch December 12, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman left review comments

Assignees
No one assigned
Labels
purs-0.14 A reminder to address this issue or merge this PR before we release PureScript v0.14.0
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman