Skip to content

Conversation

laminne
Copy link
Member

@laminne laminne commented Sep 30, 2025

close #10

概要

  • アクセス制御表を追加しました
    • v0.1で実装されるすべての操作について,どの状態のアカウントであれば実行可能であるかを示したものです

追加情報

  • 網羅的ではないのでもう少し詰めたい感じがあります

@laminne laminne requested a review from Copilot September 30, 2025 04:07
@laminne laminne self-assigned this Sep 30, 2025
@laminne laminne added the T: docs Document Changes label Sep 30, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an access control table to the authorization documentation, providing a comprehensive matrix showing which operations can be performed by accounts in different states and roles. The changes replace a simplified operation overview with detailed permission specifications for all v0.1 operations.

  • Reorganized role descriptions to focus on account state modification capabilities
  • Added comprehensive access control tables for Account, Note, Drive/Medium, Timeline/List, and Notification operations
  • Introduced standardized notation system with legends for permission states

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@laminne laminne marked this pull request as draft September 30, 2025 06:52
@laminne laminne requested a review from Copilot October 4, 2025 12:23
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


※ Y: 操作、閲覧が可能 / N: 操作、閲覧が不可能
ロールはアカウントに対する権限の集合を示すものである.\
複数のロールを持つことはできず、1つのアカウントに対して1つのロールが設定される.\\
Copy link

Copilot AI Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 6 has an extra backslash at the end that should be removed.

Suggested change
複数のロールを持つことはできず、1つのアカウントに対して1つのロールが設定される.\\
複数のロールを持つことはできず、1つのアカウントに対して1つのロールが設定される.\

Copilot uses AI. Check for mistakes.


| 操作 | Status:Active | Status:NotActivated | Role:Normal | Role:Moderator | Role:Admin | Frozen:Frozen | Not Signed in | 備考 |
| :----------------: | :-----------: | :-----------------: | :---------: | :------------: | :--------: | :-----------: | :-----------: | :--: |
| Note::Create(投稿) | Yes | No | Yes | Yes | Yes | No | | |
Copy link

Copilot AI Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table has an empty cell in the 'Not Signed in' column for Note::Create operation. This should be explicitly marked as 'No' for clarity.

Suggested change
| Note::Create(投稿) | Yes | No | Yes | Yes | Yes | No | | |
| Note::Create(投稿) | Yes | No | Yes | Yes | Yes | No | No | |

Copilot uses AI. Check for mistakes.

| Bookmark::Fetch | Yes | No | Yes | Yes | Yes | No | No | |
| Bookmark::Delete | Yes | No | Yes | Yes | Yes | No | No | |
| Reaction::Create | Yes | No | Yes | Yes | Yes | No | No | |
| Reaction::Fetch | Yes | No | Yes | Yes*(Role:Normalなアカウントのみ) | Yes*(Role:Admin**以外**に実行可能) | No | Yes | |
Copy link

Copilot AI Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Reaction::Fetch operation allows 'Not Signed in' users to fetch reactions (marked as 'Yes'), but requires authentication for other roles. This seems inconsistent - anonymous users shouldn't have more permissions than authenticated users.

Suggested change
| Reaction::Fetch | Yes | No | Yes | Yes*(Role:Normalなアカウントのみ) | Yes*(Role:Admin**以外**に実行可能) | No | Yes | |
| Reaction::Fetch | Yes | No | Yes | Yes*(Role:Normalなアカウントのみ) | Yes*(Role:Admin**以外**に実行可能) | No | No | |

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: docs Document Changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: アクセス制御/権限に関するドキュメントを追加する

1 participant