Added tests to verify if there is no channel name duplications #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scribe and heartbeat URLs
marcin-cebo
requested review from
jakub-grzesiowski,
jguz-pubnub,
kleewho and
parfeon
as code owners
jguz-pubnub
reviewed
Oct 22, 2025
| clientConfig = { | ||
| httpLoggingInterceptor = | ||
| HttpLoggingInterceptor { message -> | ||
| // Intercept subscribe GET request |
There was a problem hiding this comment.
What happens if the now-deprecated HttpLoggingInterceptor gets removed? Are there any better alternatives like capturing outgoing HTTP requests with structured data instead of just plain text logs?
There was a problem hiding this comment.
Instead of HttpLoggingInterceptor customLogger could be used. I will rewrite those test.
jguz-pubnub
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in subscribe and heartbeat URLs