Skip to content

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 21, 2019

Cleans up #100, and fixes some build errors that appeared after the cleanup.

JSHint logs

Running "jshint:source" (jshint) task

   src/edit/DistortableImage.Edit.js
    335 |    _toggleExport: function (){
                          ^ Duplicate key '_toggleExport'.

>> 1 error in 11 files
Warning: Task "jshint:source" failed. Use --force to continue.

Aborted due to warnings.

Karma logs

Running "karma:development:start" (karma) task
22 02 2019 01:09:54.219:ERROR [config]: Error inconfig file!
 TypeError: Path must be a string. Received null
  at assertPath (path.js:28:11)
  at Object.extname (path.js:1456:5)
  at phantomJSExePath (/home/champagnepapi/Desktop/workspace/ldi/node_modules/karma-phantomjs-launcher/index.js:18:12)
  at Object.<anonymous> (/home/champagnepapi/Desktop/workspace/ldi/node_modules/karma-phantomjs-launcher/index.js:107:12)
  at Module._compile (module.js:652:30)
  at Object.Module._extensions..js (module.js:663:10)
  at Module.load (/home/champagnepapi/Desktop/workspace/ldi/node_modules/coffeescript/lib/coffee-script/register.js:45:36)
  at tryModuleLoad (module.js:505:12)
  at Function.Module._load (module.js:497:3)
  at Module.require (module.js:596:17)
  at require (internal/module.js:11:18)
  at module.exports (/home/champagnepapi/Desktop/workspace/ldi/test/karma.conf.js:14:7)
  at Object.parseConfig (/home/champagnepapi/Desktop/workspace/ldi/node_modules/karma/lib/config.js:393:5)
  at new Server (/home/champagnepapi/Desktop/workspace/ldi/node_modules/karma/lib/server.js:66:24)
  at Object.<anonymous> (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt-karma/tasks/grunt-karma.js:140:20)
  at Object.<anonymous> (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/grunt/task.js:252:15)
  at Object.thisTask.fn (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/grunt/task.js:70:16)
  at Object.<anonymous> (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/util/task.js:294:30)
  at Task.runTaskFn (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/util/task.js:244:24)
  at Task.<anonymous> (/home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/util/task.js:293:12)
  at /home/champagnepapi/Desktop/workspace/ldi/node_modules/grunt/lib/util/task.js:220:11
  at _combinedTickCallback (internal/process/next_tick.js:131:7)
  at process._tickCallback (internal/process/next_tick.js:180:9)

@rexagod
Copy link
Member Author

rexagod commented Feb 21, 2019

Pinging @jywarren.

@jywarren
Copy link
Member

Ah thanks and sorry for the mess!

@jywarren jywarren merged commit e5d260e into publiclab:main Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants