Skip to content

Conversation

@DanielSant0s
Copy link
Contributor

This PR fixes libmpeg and it's sample code.

Change registers to N32 ABI standards.
Fix $at usage, changing it for $t8 and/or using "use no/at".
Fix sample code primitive offset values.
Restore Assembly source compilation, since the C source doesn't work yet.

@fjtrujy
Copy link
Member

fjtrujy commented May 5, 2025

Please, @uyjulian, take a look. I remember you were trying to make it work.

Why were you trying to make the C version?
Usually, I prefer to have the C version as it is easy to understand, but watching the ASM code, I see how it is using plenty of ASM instructions that our current GCC version is not emitting isn't?

@DanielSant0s
Copy link
Contributor Author

DanielSant0s commented May 5, 2025

Why were you trying to make the C version? Usually, I prefer to have the C version as it is easy to understand, but watching the ASM code, I see how it is using plenty of ASM instructions that our current GCC version is not emitting isn't?

We could keep the ASM code until C version get fixed. In fact it has a different code style and instruction support since quadwords aren't native on the current toolchain

@uyjulian
Copy link
Member

uyjulian commented May 5, 2025

The main issue I was having is the site where the sample files were located is no longer up

@DanielSant0s
Copy link
Contributor Author

The main issue I was having is the site where the sample files were located is no longer up

I did some sample to test it using TMPGEnc, you can get by demuxing a PSS too. So it's actually tested.

@DanielSant0s
Copy link
Contributor Author

DanielSant0s commented May 5, 2025

@uyjulian Here's the video file I used to test: Link

@Ziemas
Copy link
Contributor

Ziemas commented May 5, 2025

Do we know if this code was originally decompiled from some known library?

@uyjulian
Copy link
Member

uyjulian commented May 5, 2025

SMS or libmpeg, probably

@fjtrujy
Copy link
Member

fjtrujy commented May 6, 2025

Let's merge it as it is not hurting anyone.
@uyjulian, @DanielSant0s , @Ziemas feel free to improve the existing tests attaching new files if needed, in this way we can keep the feature working in a easier way

@fjtrujy fjtrujy merged commit b1d7c1a into ps2dev:master May 6, 2025
3 checks passed
362053534 pushed a commit to 362053534/ps2sdk that referenced this pull request Jul 28, 2025
362053534 added a commit to 362053534/ps2sdk that referenced this pull request Aug 2, 2025
362053534 added a commit to 362053534/ps2sdk that referenced this pull request Aug 2, 2025
362053534 pushed a commit to 362053534/ps2sdk that referenced this pull request Aug 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants