fix(cli): fix relative path to Google pb files #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-fenster
approved these changes
Feb 2, 2023
alexander-fenster
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading from 6.7 to 7.0 we encountered a possible bug in resolving the paths to the included Google protobuf files. With the older version, when the CLI was bundled in the same library, on line 81 of
cli/pbjs.js,__dirnamewas[..]/node_modules/protobufjs/cli, sopath.join(__dirname, "..")evaluated to[..]/node_modules/protobufjs, but now__dirnameis[..]/node_modules/protobufjs-cli, sopath.join(__dirname, "..")is just[..]/node_modules, and later, on lines 198--200, protobuf files are searched from a non-existing folder, for example[..]/node_modules/google/protobuf/descriptor.proto.This PR inserts the missing
protobufjsdirectory to the search path.