promhttp: implement WithXFromContext in terms of WithXFromRequest #1863
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds WithLabelFromRequest and WithExemplarFromRequest options and updates FromContext counterparts to be a convenience wrappers for these options.
For example, without this change, setting a label based on http.Request.Pattern requires some juggling with context:
promhttp.WithLabelFromRequest allows to access http.Request directly: