Skip to content

process_collector: merge wasip1 and js into a single implementation #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2024
Merged

process_collector: merge wasip1 and js into a single implementation #1644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions prometheus/process_collector_js.go
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions prometheus/process_collector_wasip1.go → prometheus/process_collector_wasip1_js.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

//go:build wasip1
// +build wasip1
//go:build wasip1 || js
// +build wasip1 js

package prometheus

Expand All @@ -24,7 +24,7 @@ func (c *processCollector) processCollect(ch chan<- Metric) {
c.errorCollectFn(ch)
}

// describe returns all descriptions of the collector for wasip1.
// describe returns all descriptions of the collector for wasip1 and js.
// Ensure that this list of descriptors is kept in sync with the metrics collected
// in the processCollect method. Any changes to the metrics in processCollect
// (such as adding or removing metrics) should be reflected in this list of descriptors.
Expand Down