Fixed promhttp Instrument* handlers. #1253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-rbarreda
approved these changes
Apr 18, 2023
beorn7
approved these changes
Apr 26, 2023
Member
beorn7
left a comment
beorn7
left a comment
There was a problem hiding this comment.
Besides coding style nit.
And one more thought: Perhaps add do the doc comment of WithExemplarFromContext that using that option with a observer implementation that doesn't support exemplars will panic.
Member
|
Could we expedite this and cut a 1.15.1 with it soon? See prometheus/pushgateway#550 as an example for the fallout. |
Member
Author
|
Yup, will do, thanks for ping! |
…ar (#1235)" This reverts commit 3ce88f3. Signed-off-by: bwplotka <[email protected]>
Signed-off-by: bwplotka <[email protected]>
Member
Author
|
I decided to switch direction and revert 3ce88f3 commit & add quick commentary. Might be better to avoid panics even in cost of confusion for people "why their exemplars don't work" |
Member
Author
|
Sorry @dimonl for bad suggestion on this one 🙈 |
Member
Author
|
Merging, since it's a revert and tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately optionality is important as not every e.g. ObserverVec implements exemplar (e.g. summary).
For counters this is not that needed - but changed for consistency and readability.