`--auto-discover-databases` is failing DSN validation

[fahrradflucht]

Following https://github.com/wrouesnel/postgres_exporter#setting-the-postgres-servers-data-source-name and https://github.com/wrouesnel/postgres_exporter#automatically-discover-databases I expected this to work:

bash-5.0$ DATA_SOURCE_NAME="user=postgres host=/var/run/postgresql/ sslmode=disable" postgres_exporter --auto-discover-databases --log.level debug
INFO[0000] Established new database connection to "/var/run/postgresql/:5432".  source="postgres_exporter.go:777"
DEBU[0000] Querying Postgres Version on "/var/run/postgresql/:5432"  source="postgres_exporter.go:1212"
INFO[0000] Semantic Version Changed on "/var/run/postgresql/:5432": 0.0.0 -> 11.4.0  source="postgres_exporter.go:1229"
DEBU[0000] pg_xlog_location_diff is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] replay_location is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] flush_location is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] write_location is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] sent_location is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] procpid is being forced to discard due to version incompatibility.  source="postgres_exporter.go:504"
DEBU[0000] Querying pg_setting view on "/var/run/postgresql/:5432"  source="pg_setting.go:15"
DEBU[0000] Querying namespace:  pg_stat_activity         source="postgres_exporter.go:1192"
DEBU[0000] Querying namespace:  pg_stat_bgwriter         source="postgres_exporter.go:1192"
DEBU[0000] Querying namespace:  pg_stat_database         source="postgres_exporter.go:1192"
DEBU[0000] Querying namespace:  pg_stat_database_conflicts  source="postgres_exporter.go:1192"
DEBU[0000] Querying namespace:  pg_locks                 source="postgres_exporter.go:1192"
DEBU[0000] Querying namespace:  pg_stat_replication      source="postgres_exporter.go:1192"
ERRO[0000] Error opening connection to database (postgres): malformed dsn "postgres"  source="postgres_exporter.go:1336"
ERRO[0000] Error opening connection to database (template1): malformed dsn "template1"  source="postgres_exporter.go:1336"
ERRO[0000] Error opening connection to database (template0): malformed dsn "template0"  source="postgres_exporter.go:1336"
INFO[0000] Starting Server: :9187                        source="postgres_exporter.go:1437"

[chrisdrew1]

I have the same issue. I installed the latest version locally and I am seeing the same issue.

DATA_SOURCE_NAME="user=postgres port=5432 sslmode=disable" PG_EXPORTER_EXTEND_QUERY_PATH="/home/postgres/queries.yaml" ./postgres_exporter --auto-discover-databases
INFO[0000] Established new database connection to "localhost:5432". source="postgres_exporter.go:777"
ERRO[0000] Error opening connection to database (template0): malformed dsn "template0" source="postgres_exporter.go:1336"
ERRO[0000] Error opening connection to database (testr1): malformed dsn "testr1" source="postgres_exporter.go:1336"
ERRO[0000] Error opening connection to database (keycloak): malformed dsn "keycloak" source="postgres_exporter.go:1336"

[rhys-evans]

Hi

I am seeing the same (postgres 10.10.0) . I have tried various datasource combinations

Thanks

[womchik]

Hi!

Ubuntu 18.04 psql 10.9 has the same issue

[sfalkon]

Try
DATA_SOURCE_NAME="postgresql://postgres@127.0.0.1:5432/?sslmode=disable"

[kiranjain2]

I have the same issue

time="2019-09-23T13:05:12Z" level=info msg="Established new database connection to \"postgres.local:5524\"." source="postgres_exporter.go:777"
time="2019-09-23T13:05:12Z" level=error msg="Error opening connection to database (postgresql://admin:PASSWORD_REMOVED@postgres.local:5524/template0?sslmode=disable\n): pq: database \"template0\" is not currently accepting connections" source="postgres_exporter.go:1336"

[sfalkon]

By default, you can not connect to db template0.

[OlleLarsson]

Any updates regarding this issue? I am stuck on this as well.

DATA_SOURCE_NAME="user=postgres_exporter host=/var/run/postgresql database=postgres" PG_EXPORTER_AUTO_DISCOVER_DATABASES="true"

[mungo312]

We have the same problems:
Jan 27 13:21:34 rundeck postgres_exporter[30489]: time="2020-01-27T13:21:34+01:00" level=error msg="Error opening connection to database (rundeck): malformed dsn \"rundeck\"" source="postgres_exporter.go:1474"

[ItgLvb]

Have same error:

time="2020-02-28T13:15:18Z" level=info msg="Semantic Version Changed on \"/var/run/postgresql/:5432\": 0.0.0 -> 9.6.16" source="postgres_exporter.go:1405"
time="2020-02-28T13:15:25Z" level=error msg="Error opening connection to database (nominatim): malformed dsn \"nominatim\"" source="postgres_exporter.go:1474"
time="2020-02-28T13:15:25Z" level=info msg="Starting Server: 0.0.0.0:9187" source="postgres_exporter.go:1672" 

[xmath279]

The issue seems to only occur when using the socket (/var/run/postgresql) for connecting to the database. The PR from @mungo312 seems to correct this issue. Is it possible to consider it?