- Collector values restructured based on https://github.com/kubernete… #5906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/kube-state-metrics/blob/main/internal/store/builder.go#L326-L360 - New grants added following https://github.com/prometheus-community/helm-charts/pull/5357/files for rolebindings and serviceaccounts Signed-off-by: Ramon Gordillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm collector values and roles are better aligned with
builder.go#L326-L360
@dotdc, @mrueg, @tariq1890
What this PR does / why we need it
The serviceaccount and rolebindings collector fails for missing permissions.
Which issue this PR fixes
Special notes for your reviewer
values.yaml and roles.yaml restructured for easier aligning with the collector source code.