-
-
Notifications
You must be signed in to change notification settings - Fork 188
add the example 'caching_and_replay' which uses Mesa-Replay #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I tried to lint the README.md via https://vale.sh/, as an experiment. I found that it said "cachable" is not a thing. According to mikebronner/laravel-model-caching#159, "cacheable" occurs ~9x more often than "cachable". And so, I think we should use "cacheable". As a side note, I think we should have a prose linter for the repo. Haven't decided yet which one to use. Contenders: https://github.com/errata-ai/vale#functionality. |
So cool to see this. It is always nice to see libraries coming up to populate the mesa ecosystem! I am excited to take a closer look at the library and am positive about this PR being mergeable. |
Pressed the wrong button. Wanted to say that one more use case would be to resume execution of a simulation run at a checkpoint. |
Renamed cachable to cacheable in both the mesa-replay repo and in this example. |
I will add something like a "go_to_step(step: int)" function and a step_backwards() function to cacheable_model. This could then be integrated into the UI to allow the user to jump to some step or move backwards. Edit: I think I will go with just a function to resume at some checkpoint because moving backwards would make this a little more complicated. It would be easily possible with the regular CacheableModel, but it would not be with StreamingCacheable model. |
No worries about this one for this PR. I will open an issue in https://github.com/Logende/mesa-replay. |
Already implemented and tested 😸 |
cc: @snunezcr. Finally, we are having a model replay feature! |
…does not use Python decorators
I want just to say that we should really try to merge |
That's the plan. Currently, it's a separate repo so that it's more convenient to do breaking changes. Also, the cache size is too big at the moment. @jackiekazil any comments? |
Merging now. Thank you @Logende ! |
No description provided.