Skip to content

fix acc for AWs that never completes but genericItem completes #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 10, 2023
Merged

fix acc for AWs that never completes but genericItem completes #460

merged 8 commits into from
Jul 10, 2023

Conversation

@asm582
Copy link
Member

@asm582 asm582 commented Jul 7, 2023

No description provided.

z103cb
z103cb previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@z103cb z103cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but is hard to judge is correctness due to the failing build.

@asm582 asm582 requested a review from tardieu July 7, 2023 19:29
@asm582
Copy link
Member Author

asm582 commented Jul 7, 2023

Looks ok, but is hard to judge is correctness due to the failing build.

Thanks for reviewing, now the test cases are passing

@asm582
Copy link
Member Author

asm582 commented Jul 10, 2023

@z103cb can you please review this PR?

@asm582 asm582 merged commit 75faa9e into project-codeflare:main Jul 10, 2023
@asm582 asm582 mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tardieu tardieu Awaiting requested review from tardieu

1 more reviewer

@z103cb z103cb z103cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asm582 @z103cb