remove kubectl installation from Dockerfile #447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
suggested changes
Jun 28, 2023
Contributor
z103cb
left a comment
z103cb
left a comment
There was a problem hiding this comment.
You've missed line 22
COPY --from=BUILDER /workdir/kubectl /usr/local/bin
Contributor
Author
|
I found this in the testing directory. Is the Dockerfile installing |
z103cb
approved these changes
Jun 30, 2023
kubectl doesn't seem to be in use anywhere within the code, so removing it from the Dockerfile should simplify the image creation and shrink the image size somewhat Signed-off-by: Kevin <[email protected]>
Contributor
|
@KPostOffice feel free to merge this if you have no rights, I will merge it in the morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl doesn't seem to be in use anywhere within the code, so removing it from the Dockerfile should simplify the image creation and shrink the image size somewhat