Skip to content

add markdown explaining quotamanagement and annotated example #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2023
Merged

add markdown explaining quotamanagement and annotated example #393

merged 1 commit into from
Jun 11, 2023

Conversation

@KPostOffice
Copy link
Contributor

@KPostOffice KPostOffice commented May 23, 2023

No description provided.

@KPostOffice KPostOffice requested a review from asm582 May 23, 2023 20:52
@KPostOffice KPostOffice added the documentation Improvements or additions to documentation label May 23, 2023
asm582
asm582 previously approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@asm582 asm582 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the Nit, thanks

@tardieu tardieu mentioned this pull request May 25, 2023
Closed
@KPostOffice
Copy link
Contributor Author

KPostOffice commented May 25, 2023

@asm582 I want to do some behavior by example and I'm debating between linking to the testing issues vs creating individual descriptions. Right now I'm leaning toward the former. WDYT?

@asm582
Copy link
Member

asm582 commented May 25, 2023

@asm582 I want to do some behavior by example and I'm debating between linking to the testing issues vs creating individual descriptions. Right now I'm leaning toward the former. WDYT?

is the task related to quota management documentation?

@KPostOffice
Copy link
Contributor Author

KPostOffice commented May 30, 2023

@asm582 I want to do some behavior by example and I'm debating between linking to the testing issues vs creating individual descriptions. Right now I'm leaning toward the former. WDYT?

is the task related to quota management documentation?

I'm just talking about the test cases that we talked through that I've opened issues for.

@KPostOffice KPostOffice force-pushed the quotamanagement-quickstart branch from 8f410c3 to a776721 Compare June 1, 2023 13:42
@asm582 asm582 merged commit af95bbe into project-codeflare:main Jun 11, 2023
@KPostOffice KPostOffice mentioned this pull request Jun 26, 2023
Open
Srihari1192 pushed a commit to Srihari1192/multi-cluster-app-dispatcher that referenced this pull request Jul 6, 2023
@KPostOffice @Srihari1192
add markdown explaining quotamanagement and annotated example (projec…
2559927 
…t-codeflare#393)

Signed-off-by: Kevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asm582 asm582 asm582 left review comments

+1 more reviewer

@z103cb z103cb z103cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KPostOffice @asm582 @z103cb