fix: jobinfo clone, duplicated task resource #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z103cb
approved these changes
May 5, 2023
Contributor
z103cb
left a comment
z103cb
left a comment
There was a problem hiding this comment.
@lowang-bh thank you for your contribution. I appreciate the unit-test submission. This PR is looking good.
Contributor
Author
|
Hi @z103cb , how can we make the CI succeed? |
Member
|
@lowang-bh We have restarted the build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clone job info, the Allocated/TotalRequest resource will be added as task added to jobinfo, so don't need to clone it.