Adjust CodeFlare SDK tests to run on FIPS #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oksanabaza
force-pushed
the
adjust-tests
branch
from
a6714f2 to
e451f92
Compare
KPostOffice
reviewed
Sep 10, 2024
oksanabaza
force-pushed
the
adjust-tests
branch
from
e451f92 to
abb982d
Compare
Contributor
abhijeet-dhumal
left a comment
abhijeet-dhumal
left a comment
There was a problem hiding this comment.
/lgtm
Verified by running the mnist_ray_sdk_oauth test in FIPS enabled cluster with and without this PR update
Thanks @oksanabaza, Awesome work!
Before :
After:
Fiona-Waters
approved these changes
Sep 18, 2024
Contributor
Fiona-Waters
left a comment
Fiona-Waters
left a comment
There was a problem hiding this comment.
Was able to run successfully on a fips enabled cluster. Great work Oksana.
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fiona-Waters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
https://issues.redhat.com/browse/RHOAIENG-12655
What changes have been made
Made minor fixes to the MNIST dataset download by customizing the MD5 check handling
Verification steps
E2E tests should run successfully on the FIPS cluster
Checks