-
Notifications
You must be signed in to change notification settings - Fork 58
install py-3.11 for sync #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install py-3.11 for sync #655
Conversation
|
https://github.com/KPostOffice/notebooks/pull/1/files See example PR from this workflow (successfully updates 3.11 Pipfiles |
Bobbins228
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Kevin <[email protected]>
6a3e843 to
b821d01
Compare
Signed-off-by: Kevin <[email protected]>
b821d01 to
33b4fd5
Compare
|
Accidentally opened this PR upstream with the changes to the workflow file but it's here |
|
@Bobbins228 PTAL |
Bobbins228
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
nice work on shaving down the "Extracting only directories from file paths" step!
varshaprasad96
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1! Like grep over the script!
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varshaprasad96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a followup of project-codeflare#655 where the Pipfile.cpu and Pipfile.gpu support was broken. Apart from that - the array initialization was fixed and the link to this workflow is added to the raised PR description.
This is a followup of #655 where the Pipfile.cpu and Pipfile.gpu support was broken. Apart from that - the array initialization was fixed and the link to this workflow is added to the raised PR description.
Issue link
https://issues.redhat.com/browse/RHOAIENG-11541
What changes have been made
Added another version of python to be installed as part of GH action in accordance with this documentation
Verification steps
Checks