Add missing roles to create ClusterRoleBinding for CodeFlare operator #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup after MCAD removal
Contributor
|
Ran this on my openshift cluster along with codeflare-sdk main branch and kueue, and it works as expected. I was able to successfully create a ray cluster using a demo notebook. Thanks @sutaakar for allowing me to use your catalog image. |
Contributor
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AjayJagan
pushed a commit
to AjayJagan/codeflare-operator
that referenced
this pull request
Aug 7, 2025
…ocker digest to 2a88121 (project-codeflare#509) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup after MCAD removal
Issue link
https://issues.redhat.com/browse/RHOAIENG-5297
What changes have been made
Refactored and cleaned controller RBAC permissions.
Verification steps
Install CFO as a dedicated operator using OLM:
VERSIONandIMAGE_ORG_BASEenv variable, pointing to your registry and your version.make image-buildmake image-pushmake bundle-buildmake bundle-pushmake catalog-buildmake catalog-pushChecks