Skip to content

refactor: addition of rbac needed for instascale controller #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 27, 2023
Merged

refactor: addition of rbac needed for instascale controller #304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c2317d
refactor: addition of rbac needed for instascale controller
dimakis Sep 22, 2023
b3ae92b
refactor: remove duplicate permissions and remove wildcard for machin…
dimakis Sep 25, 2023
95b9201
refactor: limit resources for machine.openshift.io api group
dimakis Sep 25, 2023
ae38143
refactor: removes unneccessary permissions
dimakis Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions config/rbac/instascale_role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
---
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
creationTimestamp: null
name: instascale-role
rules:
- apiGroups:
- ""
resources:
- configmaps
verbs:
- get
- apiGroups:
- ""
resources:
- nodes
verbs:
- get
- list
- patch
- update
- apiGroups:
- ""
resourceNames:
- instascale-ocm-secret
resources:
- secrets
verbs:
- get
- apiGroups:
- apps
resources:
- deployments
verbs:
- get
- list
- watch
- apiGroups:
- apps
resources:
- machineset
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- apps
resources:
- machineset/status
verbs:
- get
Copy link
Contributor

@astefanutti astefanutti Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are MachineSet APIs really in the apps group? It seems it's a wrong duplicate of the machine.openshift.io one.

Copy link
Contributor Author

@dimakis dimakis Sep 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, I didn't think they were in the apps group, I thought first class objects like replicasets, deployments etc were.

but I was just copying what was in the original role to try get it working.

I can't really figure out why this is the case, even getting rid of those and allowing the wildcard on the machine.openshift.io group doesn't work and just returns the same error as ye got.
I also can't seem to find a machinepool resource for any api-group in any of the docs.
Any ideas here?

Copy link
Contributor

@astefanutti astefanutti Sep 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't think the error is related to the RBAC changes. I suspect there is an issue with the OCM client configuration.

- apiGroups:
- config.openshift.io
resources:
- clusterversions
verbs:
- get
- list
- watch
- apiGroups:
- machine.openshift.io
resources:
- '*'
Copy link
Contributor

@astefanutti astefanutti Sep 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could wildcard be avoided? It's generally a best practice recommended by SRE.

verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers
verbs:
- create
- delete
- get
- list
- patch
- update
- watch
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers/finalizers
verbs:
- update
- apiGroups:
- workload.codeflare.dev
resources:
- appwrappers/status
verbs:
- get
- patch
- update
12 changes: 12 additions & 0 deletions config/rbac/instascale_role_binding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
name: instascale-rolebinding
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: ClusterRole
name: instascale-role
subjects:
- kind: ServiceAccount
name: controller-manager
namespace: system