Skip to content

Add common functions for SDK test #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add common functions for SDK test #10

merged 1 commit into from
Nov 10, 2023

Conversation

@sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Nov 10, 2023 •
edited
Loading

Issue link

Common functionality for project-codeflare/codeflare-operator#399

What changes have been made

Adding common functionality for Nodes and hostname.

Verification steps

N/A

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar marked this pull request as ready for review November 10, 2023 13:58
@sutaakar sutaakar merged commit 042fb17 into project-codeflare:main Nov 10, 2023
@sutaakar sutaakar deleted the sdk-test branch November 10, 2023 15:54
@astefanutti astefanutti mentioned this pull request Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@astefanutti astefanutti astefanutti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sutaakar @astefanutti