Skip to content

Support package refactor #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 18, 2023
Merged

Support package refactor #1

merged 7 commits into from
Oct 18, 2023

Conversation

@Fiona-Waters
Copy link
Contributor

@Fiona-Waters Fiona-Waters commented Oct 13, 2023 •
edited
Loading

Issue link

project-codeflare/codeflare-operator#237

What changes have been made

  • Moved the support files from the Codeflare Operator Repo to this new separate repo for common functions.
  • Added Makefile and moved verify-imports.sh in order to be able to verify imports are correct.

Questions:

  • Do we want to group the files further within the support directory?
  • We should have an OWNERS file - Who should be added as approvers and reviewers?
  • Do we want to add PR checks for this repo now?

Verification Steps

  • Once the Codeflare Operator repo is updated to reflect these changes we can verify that everything works as expected.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

This was referenced Oct 13, 2023
Merged
Closed
@ChristianZaccaria
Copy link
Contributor

ChristianZaccaria commented Oct 13, 2023 •
edited
Loading

/lgtm /approve

astefanutti
astefanutti reviewed Oct 13, 2023
View reviewed changes
astefanutti
astefanutti reviewed Oct 17, 2023
View reviewed changes
Makefile
OPENSHIFT-GOIMPORTS ?= $(LOCALBIN)/openshift-goimports

.PHONY: openshift-goimports
openshift-goimports: $(OPENSHIFT-GOIMPORTS) ## Download openshift-goimports locally if necessary.
Copy link
Contributor

@astefanutti astefanutti Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should bring the corresponding GH actions workflows there too.

Copy link
Contributor Author

@Fiona-Waters Fiona-Waters Oct 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify_generated_files workflow added.

@Fiona-Waters Fiona-Waters merged commit 4c8cdf6 into project-codeflare:main Oct 18, 2023
@Fiona-Waters Fiona-Waters mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@astefanutti astefanutti astefanutti approved these changes

@ChristianZaccaria ChristianZaccaria ChristianZaccaria approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fiona-Waters @ChristianZaccaria @astefanutti