Skip to content

Sanitize username for use as a label #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Sanitize username for use as a label #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/webhook/appwrapper_webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ func (w *AppWrapperWebhook) Default(ctx context.Context, obj runtime.Object) err
return err
}
userInfo := request.UserInfo
aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: userInfo.Username, AppWrapperUserIDLabel: userInfo.UID}, aw.Labels)
username := utils.SanitizeLabel(userInfo.Username)
aw.Labels = utilmaps.MergeKeepFirst(map[string]string{AppWrapperUsernameLabel: username, AppWrapperUserIDLabel: userInfo.UID}, aw.Labels)
return nil
}

Expand Down
16 changes: 16 additions & 0 deletions pkg/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package utils

import (
"fmt"
"regexp"
"strconv"
"strings"

Expand Down Expand Up @@ -346,3 +347,18 @@ func ValidatePodSets(obj *unstructured.Unstructured, podSets []workloadv1beta2.A

return nil
}

var labelRegex = regexp.MustCompile(`[^-_.\w]`)

// SanitizeLabel sanitizes a string for use as a label
func SanitizeLabel(label string) string {
// truncate to max length
if len(label) > 63 {
label = label[0:63]
}
// replace invalid characters with underscores
label = labelRegex.ReplaceAllString(label, "_")
// trim non-alphanumeric characters at both ends
label = strings.Trim(label, "-_.")
return label
}