Skip to content

Conversation

@tardieu
Copy link
Member

@tardieu tardieu commented Apr 22, 2024

This PR extends the defaulting webhook to infer pod sets for components such as pods and deployments when not explicitly specified.

@tardieu tardieu requested a review from dgrove-oss April 24, 2024 17:28
@tardieu tardieu added the enhancement New feature or request label Apr 24, 2024
@tardieu tardieu marked this pull request as ready for review April 24, 2024 17:31
@dgrove-oss dgrove-oss changed the title Infer pod sets for know GVKs Infer pod sets for known GVKs Apr 24, 2024
Copy link
Collaborator

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tardieu tardieu merged commit b87fa22 into main Apr 25, 2024
@tardieu tardieu deleted the inference branch April 25, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants