Skip to content

codeflare operator: drop unused ctx parameter to setup methods #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2024
Merged

codeflare operator: drop unused ctx parameter to setup methods #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,9 +146,9 @@ func main() {
<-certsReady
setupLog.Info("Certs ready")
if ptr.Deref(cfg.WebhooksEnabled, false) {
exitOnError(controller.SetupWebhooks(ctx, mgr, cfg.AppWrapper), "unable to configure webhook")
exitOnError(controller.SetupWebhooks(mgr, cfg.AppWrapper), "unable to configure webhook")
}
exitOnError(controller.SetupControllers(ctx, mgr, cfg.AppWrapper), "unable to start controllers")
exitOnError(controller.SetupControllers(mgr, cfg.AppWrapper), "unable to start controllers")
}()

exitOnError(controller.SetupIndexers(ctx, mgr, cfg.AppWrapper), "unable to setup indexers")
Expand Down
4 changes: 2 additions & 2 deletions pkg/controller/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import (
)

// SetupControllers creates and configures all components of the AppWrapper controller
func SetupControllers(ctx context.Context, mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error {
func SetupControllers(mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error {
if awConfig.EnableKueueIntegrations {
if err := workload.WorkloadReconciler(
mgr.GetClient(),
Expand Down Expand Up @@ -67,7 +67,7 @@ func SetupControllers(ctx context.Context, mgr ctrl.Manager, awConfig *config.Ap
}

// SetupWebhooks creates and configures the AppWrapper controller's Webhooks
func SetupWebhooks(ctx context.Context, mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error {
func SetupWebhooks(mgr ctrl.Manager, awConfig *config.AppWrapperConfig) error {
if err := (&webhook.AppWrapperWebhook{
Config: awConfig,
}).SetupWebhookWithManager(mgr); err != nil {
Expand Down