Refactoring SketchException to be available outside of app
#1196
Conversation
Stefterv
changed the title
SketchException to be available outside of app
|
Hi @joshgiesbrecht, thank you again for your work on this! I just ran your branch locally and it breaks Android mode since it is looking for the SketchException class but cannot find it within the |
…ly refactored one, so alternate modes don't break.
|
I think we're good to go now. I wrote a new, very tiny processing.app.SketchException that extends the utils one, so not only does it allow other modes to work but it still plays nicely when testing if something is a processing.utils.SketchException. Once this is released, I'll submit changes to the other modes so they refer directly to the utils class, and when those are released then I'll come back and delete the extra file. Hopefully. Fingers crossed. 😆 |
|
Thank you @joshgiesbrecht! Not sure if the |
|
Deprecated marked. I didn't expect the wrappers would be necessary either, but Idea complained and said it was a compile problem, so I let it generate them. 🤷 |
|
Not sure how to connect this PR in github to the issue, but it's resolving issue #1153 |
| // temporary band-aid class to support modes which are still looking here for the now-refactored class. | ||
| // - josh giesbrecht |
There was a problem hiding this comment.
Just curious, when would this band-aid be removed?
There was a problem hiding this comment.
My plan was to submit PRs to the other supported modes to switch them over, once this is released. Then when all existing supported modes are fully switched over this could be deleted.
There was a problem hiding this comment.
Considering we do not know which 3rd party modes/tools have used this class I would expect this stub to be there for quite a while.
Refactored SketchException to live in :app:utils, as per discussion in draft PR #1164. (resubmitted because that draft PR turned into an all-out mess of unrelated commits somehow)
Before merge:
AntCloses #1153