Skip to content

Conversation

@shinytang6
Copy link
Member

@shinytang6 shinytang6 commented Feb 21, 2018

Before your pull request is reviewed and merged, make sure you

  • there are no linting errors -- npm run lint
  • code is in uniquely-named feature branch, and has been rebased on top of latest master. If you're asked to make more changes make sure you rebase onto master then too!
  • pull request is descriptively named and links to an issue number, i.e. Fixes #123

Thank you! Fixes #554

@catarak
Copy link
Member

catarak commented Feb 21, 2018

yay this looks great! maybe some of the modals should also have titles? like "my sketches" or "'s sketches" or "about"? what do you think?

@catarak
Copy link
Member

catarak commented Feb 23, 2018

perfect ✨

@catarak catarak merged commit 61560b8 into processing:master Feb 23, 2018
@shinytang6 shinytang6 deleted the change-title branch February 27, 2018 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants