Skip to content

Conversation

@Paulie-Aditya
Copy link
Contributor

Fixes #3527

Changes:
State variable was linewrap but was getting referenced as wordwrap, so even though the dispatch function was working, the state wasn't getting updated

I have verified that this pull request:

  • [ ✅] has no linting errors (npm run lint)
  • [✅ ] has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • [✅ ] is descriptively named and links to an issue number, i.e. Fixes #123

@welcome
Copy link

welcome bot commented Sep 11, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@Paulie-Aditya
Copy link
Contributor Author

Paulie-Aditya commented Sep 11, 2025

Working as expected now:

Recording.2025-09-11.130617.mp4

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this, I think this overall feels good!

It seems like the only issue here might be that the Preferences.unit.test.jsx might need to be updated to align with the changes here in the Preferences component.

I do also think it's a bit confusing to have both linewrap and wordwrap within the repository—we may want to stick to one term in the future! Maybe after this is merged in, there could be another issue for this!

@Paulie-Aditya
Copy link
Contributor Author

Paulie-Aditya commented Sep 24, 2025

Thanks so much for your work on this, I think this overall feels good!

It seems like the only issue here might be that the Preferences.unit.test.jsx might need to be updated to align with the changes here in the Preferences component.

I do also think it's a bit confusing to have both linewrap and wordwrap within the repository—we may want to stick to one term in the future! Maybe after this is merged in, there could be another issue for this!

Hey @raclim ! in the Preferences.unit.test.jsx , I already see it referencing setLineWrap, which in fact is the correct convention according to the codebase, just in case there's an error from my side, do let me know and I will do the required changes, but it looks good from my end.

Edit: the function is correct but it is referenced as wordwrap, I have changed it to linewrap everywhere in the same file for the time being, in case of any changes, do let me know

raclim
raclim previously approved these changes Sep 25, 2025
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me! Thanks so much for following up with these changes so swiftly!

Will merge this in before the end of the week!

@Paulie-Aditya
Copy link
Contributor Author

Great! Thanks!

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the extra change here! Since the tests didn't pass, I updated the naming in places that refer to the UI components. “Wordwrap” is still used in our translations, and updating the translation itself will likely need further discussion. I also added a TODO about consolidating terminology later. Since it’s a small change, I went ahead and made the updates and will merge this in!

@raclim raclim merged commit 79e8a5c into processing:develop Sep 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

word wrap off still wraps

2 participants