-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: fixed word wrap preference issue #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
Working as expected now: Recording.2025-09-11.130617.mp4 |
raclim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your work on this, I think this overall feels good!
It seems like the only issue here might be that the Preferences.unit.test.jsx might need to be updated to align with the changes here in the Preferences component.
I do also think it's a bit confusing to have both linewrap and wordwrap within the repository—we may want to stick to one term in the future! Maybe after this is merged in, there could be another issue for this!
Hey @raclim ! in the Edit: the function is correct but it is referenced as wordwrap, I have changed it to linewrap everywhere in the same file for the time being, in case of any changes, do let me know |
57cae7e to
55e6855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good to me! Thanks so much for following up with these changes so swiftly!
Will merge this in before the end of the week!
|
Great! Thanks! |
raclim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the extra change here! Since the tests didn't pass, I updated the naming in places that refer to the UI components. “Wordwrap” is still used in our translations, and updating the translation itself will likely need further discussion. I also added a TODO about consolidating terminology later. Since it’s a small change, I went ahead and made the updates and will merge this in!
Fixes #3527
Changes:
State variable was linewrap but was getting referenced as wordwrap, so even though the dispatch function was working, the state wasn't getting updated
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123